caddytls: Drop rate_limit and burst, has been deprecated#6611
Merged
francislavoie merged 1 commit intomasterfrom Oct 7, 2024
Merged
caddytls: Drop rate_limit and burst, has been deprecated#6611francislavoie merged 1 commit intomasterfrom
rate_limit and burst, has been deprecated#6611francislavoie merged 1 commit intomasterfrom
Conversation
francislavoie
force-pushed
the
drop-ondemand-ratelimit
branch
from
66d774b to
3688695
Compare
mholt
approved these changes
Oct 7, 2024
Member
mholt
left a comment
mholt
left a comment
There was a problem hiding this comment.
LGTM. Only thing I can think of is a "TODO:" comment above the Caddyfile options parsing to remind us to remove even those errors from the code after some time.
Member
Author
|
I guess so, but no harm if they stay there forever tbh. 2 liners are pretty free. |
1 task
mavimo
added a commit
to caddyserver/ingress
that referenced
this pull request
Jan 5, 2025
As consequence of: * caddyserver/caddy#6611 support for OnDemandRateLimitBurst and OnDemandRateLimitInterval has been removed.
mavimo
added a commit
to caddyserver/ingress
that referenced
this pull request
Feb 9, 2025
As consequence of: * caddyserver/caddy#6611 support for OnDemandRateLimitBurst and OnDemandRateLimitInterval has been removed.
mavimo
added a commit
to caddyserver/ingress
that referenced
this pull request
Feb 11, 2025
As consequence of: * caddyserver/caddy#6611 support for OnDemandRateLimitBurst and OnDemandRateLimitInterval has been removed.
mavimo
added a commit
to caddyserver/ingress
that referenced
this pull request
Feb 11, 2025
* chore: Bump github.com/caddyserver/caddy/v2 from 2.8.4 to 2.9.0 Bumps [github.com/caddyserver/caddy/v2](https://github.com/caddyserver/caddy) from 2.8.4 to 2.9.0. - [Release notes](https://github.com/caddyserver/caddy/releases) - [Changelog](https://github.com/caddyserver/caddy/blob/master/.goreleaser.yml) - [Commits](caddyserver/caddy@v2.8.4...v2.9.0) --- updated-dependencies: - dependency-name: github.com/caddyserver/caddy/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * feat: remove unsupported features As consequence of: * caddyserver/caddy#6611 support for OnDemandRateLimitBurst and OnDemandRateLimitInterval has been removed. --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Marco Vito Moscaritolo <[email protected]>
mohammed90
pushed a commit
to cedricziel/caddy
that referenced
this pull request
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's time to get rid of these, they're not working correctly and introduce more problems than they solve, when used.